Minimum 2 years, to become skilled in any industry, but I encourage you to have your wife, girl friend, or mum by you when you do trading. Because I've realised that they don't really like taking too much risk , and when you have them by you when you trade, you start to trade better (I don't mean that you will become a more profitable trader in the short run, but definitely, you will lose less, and over the long run, you will likely to improve your skill as well). But to do that, your personality has to be not very aggressive, and you have to listen to what others say and your motivation of trading is to feed/care your family better. This is just one way to improve your profitability.