He pay a lot of money for it.
A few hundred, or a few thousand?
1. I never really understood this logical, hopefully you can help. If someone has a trading system that works for them, why would they sell it to the world? If it so good and has good ROI, I don’t understand why anyone would sell it?
This is the key question, and the difficulty in answering this question convincingly is usually the strongest clue to the reality that this is unlikely to be an appropriate choice.
2. What the chances of the trading system eventually becoming not useable and doesn’t make money anymore.
If it has a proven edge right now, you mean? (Big assumption, there).
They're somewhere in-between "high" and "very high", probably.
But that still doesn't necessarily make it worthless, if it's working well now.
3. What questions would you ask if thinking of buying such a product?
I would ask the following ... (note that interpreting the answers to all three of these questions requires quite a bit of experience, good judgement and some real statistical understanding, which probably few potential buyers will realistically have) ...
(i) What objective, independently verified evidence is there that it has a proven edge?
(ii) Can I speak, myself, with another buyer or two (or more) who have been using the system for some months (not "anonymous testimonials" or "incentivised testimonials")?
(iii) Does it appear to be based on common-sense principles and to have some kind of collective, predictive value rather than simply being back-fitted/curve-fitted to the data which purports to verify its edge?
Without really satisfactory answers to all three of these questions, I wouldn't touch it.
More specifically, if the vendor tries to claim or imply that the second of those questions is "unreasonably demanding", from a potential buyer, I would lose interest rapidly.
In short, it's not impossible, but realities predicate that the odds are heavily stacked against this being a good idea, and the initial presumption (albeit open to correction) should certainly be that it isn't.

