My 2cents:
1. Elder is NOT a trader. He is a traders' COACH / vendor.
2. His first book "Trading for a living" was a big success (catchy title especially if you consider the timing, as everyone in the US dreamed to "make it big" in stocks in the late 1990s bullmarket). It was an OK beginner's book, to Elder's credit. Anyway, due to that book -still selling strong nowadays-, he became "famous". But his income from royalties of that book minimal.
3. So, trying to capitalise his "fame", he has been organising week-long "trading camps", typically in tropical paradise islands, to teach people about trading, with emphasis in "psychology". The rest of the time is spent on water-sports
I would say that Elder should be compared to Van Tharp.
Although the latter one was "luckier" in the sense that he was interviewed in Schwager's Market Wizards and became much more "famous". And also Tharp had contact with some "real" traders of his time, so his concepts are more useful (mostly CTAs, so it depends on your trading style).
But neither Elder nor Tharp are traders.
Finally, I found Elder's comments to Guy Ellis disturbing and his insults and arrogance annoying. My opinion of him has switched from "neutral" (of a not-too-much crooked vendor salesman, but I respected him as I would respect any self-made man) to "negative".
The world is full of idiots who are full of themselves and Elder now belongs in that category, as far as I am concerned.