This approach is correct in theory but the big problem is that you don't have the true mean, vol, and correlations, you only have estimates from your sample. Then when you optimize, you end up optimizing on the errors more than the true properties.
There are strategies used by quant funds to...